Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 8337013: Fix updating of property attributes for elements. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix updating of property attributes for elements. This fixes updating of property attributes for getters and setters on dictionary elements while redefining. This just updates the property details on the existing element. R=rossberg@chromium.org BUG=v8:1772 TEST=test262 Committed: http://code.google.com/p/v8/source/detail?r=9685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -113 lines) Patch
M src/objects.cc View 3 chunks +24 lines, -11 lines 0 comments Download
M test/test262/test262.status View 4 chunks +0 lines, -102 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 2 months ago (2011-10-18 11:19:19 UTC) #1
rossberg
9 years, 2 months ago (2011-10-18 13:24:03 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698