Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8337007: Merge r8721, r8729 and r9334 to 3.4 branch (Closed)

Created:
9 years, 2 months ago by Søren Gjesse
Modified:
9 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Merge r8721, r8729 and r9334 to 3.4 branch These should make the 3.4 branch build with GCC 4.6. This has not been verified as I have no access to GCC 4.6. Currently Dart is using V8 3.4 and therefore people with GCC have trouble building Dart (which includes V8 as a third party dependency. R=danno@chromium.org BUG=dart:138 TEST=Build V8 3.4 with GCC 4.6 Committed: http://code.google.com/p/v8/source/detail?r=9667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1404 lines, -1301 lines) Patch
M src/ia32/cpu-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/third_party/valgrind/valgrind.h View 74 chunks +1398 lines, -1290 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years, 2 months ago (2011-10-18 07:37:49 UTC) #1
danno
9 years, 2 months ago (2011-10-18 07:58:45 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698