OpenBSD patches for net, split from CR #8275005

net/dns/dns_config_service_posix.h

Index: net/dns/dns_config_service_posix.h
diff --git a/net/dns/dns_config_service_posix.h b/net/dns/dns_config_service_posix.h
index 91e03f439b72b80d6e74a9faf195ee13af9cd937..a8269e9c4417f5a9c08a237847cb3f64cab23328 100644
--- a/net/dns/dns_config_service_posix.h
+++ b/net/dns/dns_config_service_posix.h
@@ -6,6 +6,14 @@
 #define NET_DNS_DNS_CONFIG_SERVICE_POSIX_H_
 #pragma once
 
+#include "build/build_config.h"
+
+#if defined(OS_OPENBSD)
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netinet/in.h>
+#endif

[wtc, 2011/10/18 21:50:26]

Note: it may be better to use a forward declaration of
struct __res_state in this header, and move the system
header inclusions to .cc files.

I recommend removing the #if defined(OS_OPENBSD).

Is <sys/socket.h> necessary?  From what I found in old Unix
man pages, these headers should be included:

#include <sys/types.h>
#include <netinet/in.h>
#include <arpa/nameser.h>
#include <resolv.h>

http://download.oracle.com/docs/cd/E19109-01/tsolaris8/835-8004/6ruu29hft/ind...
http://publib.boulder.ibm.com/infocenter/pseries/v5r3/index.jsp?topic=/com.ib...
http://nixdoc.net/man-pages/Tru64/res_mkquery.3.html

[Robert Nagy, 2011/10/19 07:10:02]

Yes it makes sense to include these headers everywhere. Which i've done in the
new patchset, but I kept them in the header file.

+
 #include <resolv.h>
 
 #include "base/compiler_specific.h"