OpenBSD patches for net, split from CR #8275005

net/dns/dns_config_service_posix.h

Index: net/dns/dns_config_service_posix.h
diff --git a/net/dns/dns_config_service_posix.h b/net/dns/dns_config_service_posix.h
index 91e03f439b72b80d6e74a9faf195ee13af9cd937..4f9255d722f61db2a7615f7e201990431f57d5cf 100644
--- a/net/dns/dns_config_service_posix.h
+++ b/net/dns/dns_config_service_posix.h
@@ -6,6 +6,11 @@
 #define NET_DNS_DNS_CONFIG_SERVICE_POSIX_H_
 #pragma once
 
+#include "build/build_config.h"

[wtc, 2011/10/19 22:34:27]

Please remove this.  I believe this is not necessary now.

[Robert Nagy, 2011/10/20 07:37:43]

Done.

+
+#include <sys/types.h>

[cbentzel, 2011/10/19 19:35:18]

Should this includes be nested within OPENBSD conditionals?

[Robert Nagy, 2011/10/19 19:49:34]

I think it is totally fine on every posix system, and the less ifdefs we have,
the better.

[wtc, 2011/10/19 22:34:27]

<sys/types.h> used to be required on Unix in the early 1990s.
It is no longer required on most Unix platforms today, but
still required by OpenBSD.  It is harmless to include
<sys/types.h>.

+#include <netinet/in.h>
+#include <arpa/nameser.h>

[wtc, 2011/10/19 22:34:27]

Don't add <arpa/nameser.h> unless it's required by OpenBSD.

Note: in this file, we should include only the headers
required for the definition of struct __res.  All the other
system headers should be moved to dns_config_service_posix.cc.
So you need to read the compiler errors of
dns_config_service_posix.cc carefully and figure out which
system headers should be included by
dns_config_service_posix.h and which should be included by
dns_config_service_posix.cc.

[Robert Nagy, 2011/10/20 07:37:43]

I've removed nameser.h, but the others has to stay. __res is in resolv.h that
needs netinet/in.h and that needs sys/types.h.

 #include <resolv.h>
 
 #include "base/compiler_specific.h"