Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/objects-debug.cc

Issue 8336021: Fix ASSERT by reordering the initialization of the arguments boilerplate. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 256
257 257
258 void ExternalDoubleArray::ExternalDoubleArrayVerify() { 258 void ExternalDoubleArray::ExternalDoubleArrayVerify() {
259 ASSERT(IsExternalDoubleArray()); 259 ASSERT(IsExternalDoubleArray());
260 } 260 }
261 261
262 262
263 void JSObject::JSObjectVerify() { 263 void JSObject::JSObjectVerify() {
264 VerifyHeapPointer(properties()); 264 VerifyHeapPointer(properties());
265 VerifyHeapPointer(elements()); 265 VerifyHeapPointer(elements());
266
267 if (GetElementsKind() == NON_STRICT_ARGUMENTS_ELEMENTS) {
268 ASSERT(this->elements()->IsFixedArray());
269 ASSERT(this->elements()->length() >= 2);
270 }
271
266 if (HasFastProperties()) { 272 if (HasFastProperties()) {
267 CHECK_EQ(map()->unused_property_fields(), 273 CHECK_EQ(map()->unused_property_fields(),
268 (map()->inobject_properties() + properties()->length() - 274 (map()->inobject_properties() + properties()->length() -
269 map()->NextFreePropertyIndex())); 275 map()->NextFreePropertyIndex()));
270 } 276 }
271 ASSERT_EQ((map()->has_fast_elements() || map()->has_fast_smi_only_elements()), 277 ASSERT_EQ((map()->has_fast_elements() || map()->has_fast_smi_only_elements()),
272 (elements()->map() == GetHeap()->fixed_array_map() || 278 (elements()->map() == GetHeap()->fixed_array_map() ||
273 elements()->map() == GetHeap()->fixed_cow_array_map())); 279 elements()->map() == GetHeap()->fixed_cow_array_map()));
274 ASSERT(map()->has_fast_elements() == HasFastElements()); 280 ASSERT(map()->has_fast_elements() == HasFastElements());
275 } 281 }
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 ASSERT(e->IsUndefined()); 825 ASSERT(e->IsUndefined());
820 } 826 }
821 } 827 }
822 } 828 }
823 } 829 }
824 830
825 831
826 #endif // DEBUG 832 #endif // DEBUG
827 833
828 } } // namespace v8::internal 834 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698