Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 8336016: Inline 'if' in GC instrumentation (Closed)

Created:
9 years, 2 months ago by pasko-google - do not use
Modified:
9 years, 2 months ago
Reviewers:
Evgeny Eltsin, halyavin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Inline 'if' in GC instrumentation This is the same version as proposed by Evgeny, only changing the actual suspension function name back to where it was before to be able to perform less changes in libgc. Instead of __nacl_suspend_thread_if_needed (); instrumentation now looks like if (__nacl_thread_suspension_needed) __nacl_suspend_thread_if_needed (); GC runtime should define volatile int __nacl_thread_suspension_needed; void __nacl_suspend_thread_if_needed (void); BUG=http://code.google.com/p/nativeclient/issues/detail?id=2181 TEST=none Committed: http://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=1cd4b75

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -20 lines) Patch
M gcc/tree-profile.c View 2 chunks +101 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pasko-google - do not use
9 years, 2 months ago (2011-10-18 08:16:07 UTC) #1
halyavin
9 years, 2 months ago (2011-10-18 08:20:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698