Issue 8335006: Eliminate some virtual function from AST classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8335006: Eliminate some virtual function from AST classes. (Closed)

Created:
9 years, 1 month ago by fschneider

Modified:
9 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Eliminate some virtual function from AST classes. 1. Remove unused dead functions. 2. Replace the virtual As-* type cast functions with non-virtual version that uses node_type(). Result is around 13K reduction in binary size. Committed: http://code.google.com/p/v8/source/detail?r=9841

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -51 lines)			Patch
M	src/ast.h	View	10 chunks	+6 lines, -43 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages