Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: media/audio/win/audio_low_latency_input_win.cc

Issue 8335005: Changing a NOTREACHED to a LOG(WARNING) for cases when a mic isn't connected. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/audio_low_latency_input_win.cc
===================================================================
--- media/audio/win/audio_low_latency_input_win.cc (revision 107332)
+++ media/audio/win/audio_low_latency_input_win.cc (working copy)
@@ -207,7 +207,10 @@
device_role,
endpoint_device.Receive());
if (FAILED(hr)) {
- NOTREACHED() << "error code: " << hr;
+ // This will happen if there's no audio capture device found or available
+ // (e.g. some audio cards that have inputs will still report them as
+ // "not found" when no mic is plugged into the input jack).
+ LOG(WARNING) << "No audio end point: " << std::hex << hr;
return 0.0;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698