Reduces code generated by dynamic calls.

frog/member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A formal parameter to a [Method]. */
 class Parameter {
   FormalNode definition;
 
   String name;
   Type type;
@@ skipping 81 matching lines @@
 
   void provideFieldSyntax() => world.internalError('can not be field', span);
   void providePropertySyntax() =>
     world.internalError('can not be property', span);
 
   Definition get definition() => null;
 
   List<Parameter> get parameters() => [];
 
   // TODO(jimhug): Fix these names once get/set are truly pseudo-keywords.
-  abstract Value get_(MethodGenerator context, Node node, Value target);
+  // TODO(jmesserly): isDynamic isn't a great name for this, something better?
+  abstract Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic]);
 
   abstract Value set_(MethodGenerator context, Node node, Value target,
-      Value value, [bool checked]);
+      Value value, [bool isDynamic]);
 
   bool canInvoke(MethodGenerator context, Arguments args) {
     return canGet && new Value(returnType, null).canInvoke(context, '\$call', args);
   }
 
   Value invoke(MethodGenerator context, Node node, Value target, Arguments args,
-      [bool checked=true]) {
-    var newTarget = get_(context, node, target);
-    return newTarget.invoke(context, '\$call', node, args, checked);
+      [bool isDynamic=false]) {
+    var newTarget = get_(context, node, target, isDynamic);
+    return newTarget.invoke(context, '\$call', node, args, isDynamic);
   }
 
   bool override(Member other) {
     if (isStatic) {
       world.error('static members can not hide parent members',
         span, other.span);
       return false;
     } else if (other.isStatic) {
       world.error('can not override static member', span, other.span);
       return false;
@@ skipping 31 matching lines @@
 
   // If this really becomes first class, this should return typeof(Type)
   Type get returnType() => world.isVar;
 
   bool canInvoke(MethodGenerator context, Arguments args) => false;
   bool get canGet() => true;
   bool get canSet() => false;
 
   void resolve(Type inType) {}
 
-  Value get_(MethodGenerator context, Node node, Value target) {
-    // TODO(jmesserly): is just using the raw type name good enough to ensure we
-    // don't have type name collisions on the JS side?
-    // TODO(jmesserly): assert(target == null);
-    // TODO(jimhug): named args.
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
+    assert(target == null || target.type.isTop);
+    // TODO(jmesserly): named args
     return new Value(type, type.jsname, false, false, true);
   }
 
   Value set_(MethodGenerator context, Node node, Value target, Value value,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     world.error('can not set type', type.definition.span);
   }
 
   Value invoke(MethodGenerator context, Node node, Value target, Arguments args,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     world.error('can not invoke type', type.definition.span);
   }
 }
 
 /** Represents a Dart field from source code. */
 class FieldMember extends Member {
   final VariableDefinition definition;
   final Expression value;
 
   Type type;
@@ skipping 112 matching lines @@
 
       if (isStatic) {
         _computedValue = world.gen.globalForStaticField(
             this, _computedValue, [_computedValue]);
       }
       _computing = false;
     }
     return _computedValue;
   }
 
-  Value get_(MethodGenerator context, Node node, Value target) {
-    declaringType.markUsed();
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
+    if (!isDynamic) {
+      declaringType.markUsed();
+    }
     if (isStatic) {
       // Make sure to compute the value of all static fields, even if we don't
       // use this value immediately.
       var cv = computeValue();
       if (isFinal) {
         return cv;
       }
       if (declaringType.isTop) {
         return new Value(type, '$jsname');
       } else {
         return new Value(type, '${declaringType.jsname}.$jsname');
       }
     } else if (target.isConst && isFinal) {
       // take advantage of consts and retrieve the value directly if possible
       var constTarget = target is GlobalValue ? target.exp : target;
       if (constTarget is ConstObjectValue) {
         return constTarget.fields[name];
       } else if (constTarget.type == world.stringType && name == 'length') {
         return new Value(type, '${constTarget.actualValue.length}');
       }
     }
     return new Value(type, '${target.code}.$jsname');
   }
 
   Value set_(MethodGenerator context, Node node, Value target, Value value,
-      [bool checked=true]) {
-    var lhs = get_(context, node, target);
-    value = value.convertTo(context, type, node, checked);
+      [bool isDynamic=false]) {
+    var lhs = get_(context, node, target, isDynamic);
+    value = value.convertTo(context, type, node, isDynamic);
     return new Value(type, '${lhs.code} = ${value.code}');
   }
 }
 
 class PropertyMember extends Member {
   MethodMember getter;
   MethodMember setter;
 
   bool _provideFieldSyntax = false;
 
@@ skipping 29 matching lines @@
       // other.returnType.ensureAssignableFrom(returnType, null, true);
       if (other.isProperty) addFromParent(other);
       return true;
     } else {
       world.error('property can only override field or property',
         span, other.span);
       return false;
     }
   }
 
-  Value get_(MethodGenerator context, Node node, Value target) {
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
     if (getter == null) {
-      // TODO(jmesserly): fix this! should call noSuchMethod.
-      world.warning('no getter on ${declaringType.name}.$name', node.span);
-      return new Value(null, '${target.code}.$name()/*NoGetter*/');
+      return target.invokeNoSuchMethod(context, 'get:$name', node);
     }
     return getter.invoke(context, node, target, Arguments.EMPTY);
   }
 
   Value set_(MethodGenerator context, Node node, Value target, Value value,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     return setter.invoke(context, node, target, new Arguments(null, [value]),
-      checked);
+      isDynamic);
   }
 
   addFromParent(Member parentMember) {
     // TODO(jimhug): Egregious Hack!
     if (parentMember is ConcreteMember) {
       parentMember = parentMember.baseMember;
     }
 
     if (getter == null) getter = parentMember.getter;
     if (setter == null) setter = parentMember.setter;
@@ skipping 66 matching lines @@
   Definition set initDelegate(ctor) { baseMember.initDelegate = ctor; }
 
   Type resolveType(TypeReference node, bool isRequired) {
     var type = baseMember.resolveType(node, isRequired);
     return type.resolveTypeParams(declaringType);
   }
 
   // TODO(jimhug): Add support for type params.
   bool override(Member other) => baseMember.override(other);
 
-  Value get_(MethodGenerator context, Node node, Value target) {
-    Value ret = baseMember.get_(context, node, target);
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
+    Value ret = baseMember.get_(context, node, target, isDynamic);
     return new Value(returnType, ret.code);
   }
 
   Value set_(MethodGenerator context, Node node, Value target, Value value,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     // TODO(jimhug): Check arg types in context of concrete type.
-    Value ret = baseMember.set_(context, node, target, value, checked);
+    Value ret = baseMember.set_(context, node, target, value, isDynamic);
     return new Value(returnType, ret.code);
   }
 
   Value invoke(MethodGenerator context, Node node, Value target, Arguments args,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     // TODO(jimhug): Check arg types in context of concrete type.
-    Value ret = baseMember.invoke(context, node, target, args, checked);
+    Value ret = baseMember.invoke(context, node, target, args, isDynamic);
     var code = ret.code;
     if (isConstructor) {
       // TODO(jimhug): Egregious hack - won't live through the weekend.
       code = code.replaceFirst(
           declaringType.genericType.jsname, declaringType.jsname);
     }
-    world.gen.genMethod(this);
+    declaringType.genMethod(this);
     return new Value(returnType, code);
   }
 }
 
 
 /** Represents a Dart method or top-level function. */
 class MethodMember extends Member {
   FunctionDefinition definition;
   Type returnType;
   List<Parameter> parameters;
@@ skipping 119 matching lines @@
     return type;
   }
 
   bool get prefersPropertySyntax() => true;
   bool get requiresFieldSyntax() => false;
 
   void provideFieldSyntax() => _provideFieldSyntax = true;
   void providePropertySyntax() => _providePropertySyntax = true;
 
   Value set_(MethodGenerator context, Node, Value target, Value value,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     world.error('can not set method', definition.span);
   }
 
-  Value get_(MethodGenerator context, Node node, Value target) {
-    world.gen.genMethod(this); // TODO(jimhug): Would prefer to invoke!
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
+    // TODO(jimhug): Would prefer to invoke!
+    declaringType.genMethod(this);
     _provideOptionalParamInfo = true;
     if (isStatic) {
       var type = declaringType.isTop ? '' : '${declaringType.jsname}.';
       return new Value(functionType, '$type$jsname');
     }
     _providePropertySyntax = true;
     return new Value(functionType, '${target.code}.get\$$jsname()');
   }
 
   bool namesInOrder(Arguments args) {
@@ skipping 33 matching lines @@
   genParameterValues() {
     // Pure lazy?
     for (var p in parameters) p.genValue(this, generator);
   }
 
   /**
    * Invokes this method on the given [target] with the given [args].
    * [node] provides a [SourceSpan] for any error messages.
    */
   Value invoke(MethodGenerator context, Node node, Value target,
-      Arguments args, [bool checked=true]) {
+      Arguments args, [bool isDynamic=false]) {
     // TODO(jimhug): Fix this hack for ensuring a method is resolved.
     if (parameters == null) {
       world.info('surprised to need to resolve: ${declaringType.name}.$name');
       this.resolve(declaringType);
     }
 
-    if (!isGenerated) {
-      world.gen.genMethod(this);
-    }
+    declaringType.genMethod(this);
 
     if (isStatic || isFactory) {
       declaringType.markUsed();
     }
 
     if (!namesInOrder(args)) {
       // Names aren't in order. For now, use a var call because it's an
       // easy way to get the right eval order for out of order arguments.
       return context.findMembers(name).invokeOnVar(context, node, target, args);
     }
 
     var argsCode = [];
     if (target != null && (isConstructor || target.isSuper)) {
       argsCode.add('this');
     }
 
     int bareCount = args.bareCount;
     for (int i = 0; i < bareCount; i++) {
       var arg = args.values[i];
       if (i >= parameters.length) {
         // TODO(jimhug): better error location
         var msg = _argCountMsg(args.length, parameters.length);
         return _argError(context, node, target, args, msg);
       }
-      arg = arg.convertTo(context, parameters[i].type, node, checked);
+      arg = arg.convertTo(context, parameters[i].type, node, isDynamic);
       if (isConst && arg.isConst) {
         argsCode.add(arg.canonicalCode);
       } else {
         argsCode.add(arg.code);
       }
     }
 
     if (bareCount < parameters.length) {
       genParameterValues();
 
       int namedArgsUsed = 0;
       for (int i = bareCount; i < parameters.length; i++) {
         var arg = args.getValue(parameters[i].name);
         if (arg == null) {
           arg = parameters[i].value;
         } else {
-          arg = arg.convertTo(context, parameters[i].type, node, checked);
+          arg = arg.convertTo(context, parameters[i].type, node, isDynamic);
           namedArgsUsed++;
         }
 
         if (arg == null || !parameters[i].isOptional) {
           // TODO(jimhug): better error location
           var msg = _argCountMsg(Math.min(i, args.length), i + 1, atLeast:true);
           return _argError(context, node, target, args, msg);
         } else {
           argsCode.add(isConst && arg.isConst
               ? arg.canonicalCode : arg.code);
@@ skipping 453 matching lines @@
         if (_treatAsField) {
           member.provideFieldSyntax();
         } else {
           member.providePropertySyntax();
         }
       }
     }
     return _treatAsField;
   }
 
-  Value get_(MethodGenerator context, Node node, Value target) {
-    if (members.length == 1) return members[0].get_(context, node, target);
+  Value get_(MethodGenerator context, Node node, Value target,
+      [bool isDynamic=false]) {
+    if (members.length == 1) {
+      return members[0].get_(context, node, target, isDynamic);
+    }
+    final targets = members.filter((m) => m.canGet);
+    if (targets.length == 1) {
+      return targets[0].get_(context, node, target, isDynamic);
+    }
 
     Value returnValue = null;
-    for (var member in members) {
-      if (!member.canGet) continue;
-      final value = member.get_(context, node, target);
+    for (var member in targets) {
+      final value = member.get_(context, node, target, isDynamic:true);
       returnValue = _tryUnion(returnValue, value, node);
     }
     if (returnValue == null) {
       return _makeError(node, target, 'getter');
     }
     if (returnValue.code == null) {
       if (treatAsField) {
         return new Value(returnValue.type, '${target.code}.$jsname');
       } else {
         return new Value(returnValue.type, '${target.code}.get\$$jsname()');
       }
     }
     return returnValue;
   }
 
   Value set_(MethodGenerator context, Node node, Value target, Value value,
-      [bool checked=true]) {
+      [bool isDynamic=false]) {
     if (members.length == 1) {
-      return members[0].set_(context, node, target, value, checked);
+      return members[0].set_(context, node, target, value, isDynamic);
     }
     final targets = members.filter((m) => m.canSet);
     if (targets.length == 1) {
-      return targets[0].set_(context, node, target, value, checked);
+      return targets[0].set_(context, node, target, value, isDynamic);
     }
 
     Value returnValue = null;
     for (var member in targets) {
-      final setValue = member.set_(context, node, target, value, checked:false);
-      returnValue = _tryUnion(returnValue, setValue, node);
+      final res = member.set_(context, node, target, value, isDynamic:true);
+      returnValue = _tryUnion(returnValue, res, node);
     }
     if (returnValue == null) {
       return _makeError(node, target, 'setter');
     }
     if (returnValue.code == null) {
       if (treatAsField) {
         return new Value(returnValue.type,
           '${target.code}.$jsname = ${value.code}');
       } else {
         return new Value(returnValue.type,
           '${target.code}.set\$$jsname(${value.code})');
       }
     }
     return returnValue;
   }
 
   Value invoke(MethodGenerator context, Node node, Value target,
-      Arguments args, [bool checked=true]) {
+      Arguments args, [bool isDynamic=false]) {
     if (members.length == 1) {
-      return members[0].invoke(context, node, target, args, checked);
+      return members[0].invoke(context, node, target, args, isDynamic);
     }
     final targets = members.filter((m) => m.canInvoke(context, args));
     if (targets.length == 1) {
-      return targets[0].invoke(context, node, target, args, checked);
+      return targets[0].invoke(context, node, target, args, isDynamic);
     }
 
     Value returnValue = null;
     for (var member in targets) {
-      final value = member.invoke(context, node, target, args, checked:false);
-      returnValue = _tryUnion(returnValue, value, node);
+      final res = member.invoke(context, node, target, args, isDynamic:true);
+      returnValue = _tryUnion(returnValue, res, node);
     }
 
     if (returnValue == null) {
       return _makeError(node, target, 'method');
     }
 
     // If we fail to unify the resulting code, implement as a var call.
     if (returnValue.code == null) {
       if (name.startsWith('\$')) {
         return target.invokeSpecial(name, args, returnValue.type);
@@ skipping 129 matching lines @@
   }
 
   void forEach(void f(MethodMember member)) {
     factories.forEach((_, Map constructors) {
       constructors.forEach((_, Member member) {
         f(member);
       });
     });
   }
 }