Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: vm/port_test.cc

Issue 8334031: - Fix the snapshot generation python script to return an error code when snapshot generation fail... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/port_test.cc
===================================================================
--- vm/port_test.cc (revision 1129)
+++ vm/port_test.cc (working copy)
@@ -165,7 +165,10 @@
void ThreadedPort_start(uword parameter) {
- Dart::CreateIsolate(NULL, NULL);
+ // We only need an isolate here because the MutexLocker in
+ // PortMap::CreatePort expects it, we don't need to initialize
+ // the isolate as it does not run any dart code.
+ Dart::CreateIsolate();
intptr_t remote = parameter;
intptr_t local = PortMap::CreatePort();

Powered by Google App Engine
This is Rietveld 408576698