- Fix the snapshot generation python script to return an error code when snapshot generation fail...

vm/unit_test.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_UNIT_TEST_H_
 #define VM_UNIT_TEST_H_
 
 #include "include/dart_api.h"
 
 #include "vm/ast.h"
 #include "vm/dart.h"
 #include "vm/globals.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
+#include "vm/longjump.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/zone.h"
 
 // The UNIT_TEST_CASE macro is used for tests that do not need any
 // default isolate or zone functionality.
 #define UNIT_TEST_CASE(name)                                                   \
   void Dart_Test##name();                                                      \
   static const dart::TestCase kRegister##name(Dart_Test##name, #name);         \
   void Dart_Test##name()
@@ skipping 140 matching lines @@
   virtual void Run();
 
  private:
   RunEntry* const run_;
 };
 
 
 class TestIsolateScope {
  public:
   TestIsolateScope() {
-    isolate_ = Dart::CreateIsolate(NULL, NULL);
+    isolate_ = Dart::CreateIsolate();

[Ivan Posva, 2011/11/04 17:24:42]

Why not just use the Dart_CreateIsolate call here instead of the internal calls?

[siva, 2011/11/04 22:01:57]

Good point, simplifies stuff a lot.

On 2011/11/04 17:24:42, Ivan Posva wrote:

+    LongJump jump;
+    isolate_->set_long_jump_base(&jump);
+    if (setjmp(*jump.Set()) == 0) {
+      Dart::InitializeIsolate(NULL, NULL);
+      isolate_->set_long_jump_base(NULL);
+    } else {
+      Dart::ShutdownIsolate();
+      isolate_ = NULL;
+      EXPECT(false);  // The test fails here.
+    }
     Dart_EnterScope();  // Create a Dart API scope for unit tests.
   }
   ~TestIsolateScope() {
     Dart_ExitScope();  // Exit the Dart API scope created for unit tests.
     ASSERT(isolate_ == Isolate::Current());
     Dart::ShutdownIsolate();

[Ivan Posva, 2011/11/04 17:24:42]

In the same way we should just call the Dart API entry here.

[siva, 2011/11/04 22:01:57]

Done.

     isolate_ = NULL;
   }
 
  private:
   Isolate* isolate_;
 
   DISALLOW_COPY_AND_ASSIGN(TestIsolateScope);
 };
 
 
@@ skipping 59 matching lines @@
 
 #define EXPECT_VALID(handle)                                                  \
   if (!Dart_IsValid((handle))) {                                              \
     dart::Expect(__FILE__, __LINE__).Fail("invalid handle '%s':\n    '%s'\n", \
                                           #handle, Dart_GetError(handle));    \
   }
 
 }  // namespace dart
 
 #endif  // VM_UNIT_TEST_H_