- Fix the snapshot generation python script to return an error code when snapshot generation fail...

tools/create_snapshot_file.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # Script to create snapshot files.
 
 import getopt
 import optparse
@@ skipping 78 matching lines @@
 
   # Construct the path to the dart binary.
   snapshot_argument = ''.join([ "--snapshot=", options.output_bin ])
   if not options.scripts:
     command = [ options.executable, snapshot_argument ]
   else:
     scripts = string.split(options.scripts)
     command = [ options.executable, snapshot_argument ] + scripts
   if options.verbose:
     print ' '.join(command)
-  subprocess.call(command)
+  pipe = subprocess.Popen(command,
+                          stdout=subprocess.PIPE,
+                          stderr=subprocess.PIPE)
+  out, error = pipe.communicate()
+  if (pipe.returncode != 0):
+    print out, error
+    print "Snapshot generation failed"
+    return -1
 
   if not makeFile(options.output, options.input_cc, options.output_bin):
     return -1
 
   return 0
 
 if __name__ == '__main__':
   sys.exit(Main())