Issue 8334028: Fix Runtime_ArrayConcat to handle FAST_DOUBLE_ELEMENTS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8334028: Fix Runtime_ArrayConcat to handle FAST_DOUBLE_ELEMENTS (Closed)

Created:
9 years, 1 month ago by Jakob Kummerow

Modified:
9 years, 1 month ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix Runtime_ArrayConcat to handle FAST_DOUBLE_ELEMENTS TEST=mjsunit/elements-kind.js; stanford-crypto-sha256-iterative in debug mode Committed: http://code.google.com/p/v8/source/detail?r=9880

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	src/runtime.cc	View		4 chunks	+18 lines, -0 lines	1 comment	Download
	M	test/mjsunit/elements-kind.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

9 years, 1 month ago (2011-11-04 10:02:04 UTC) #2

LGTM if you address the comment.

http://codereview.chromium.org/8334028/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8334028/diff/1/src/runtime.cc#newcode9698
src/runtime.cc:9698: case FAST_SMI_ONLY_ELEMENTS:
Add all of the other elements kinds explicitly to the case that either are
UNREACHABLE or return length, remove the default.

Expand Messages | Collapse Messages