Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 8334010: History: Hide 'edit items' button when there are no items to display. (Closed)

Created:
9 years, 2 months ago by NaveenBobbili (Motorola)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

History: Hide 'edit items' button when there are no items to display. BUG=37978 TEST=Verify that history page with zero items should not display Edit Items button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106251

Patch Set 1 #

Patch Set 2 : Added my primary account in AUTHORS file. #

Total comments: 1

Patch Set 3 : Corrected the AUTHORS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/history.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
NaveenBobbili (Motorola)
This is a clone of http://codereview.chromium.org/8118001/. Sorry for the inconvenience.
9 years, 2 months ago (2011-10-18 04:33:24 UTC) #1
Evan Stade
lgtm
9 years, 2 months ago (2011-10-18 20:50:48 UTC) #2
NaveenBobbili (Motorola)
On 2011/10/18 20:50:48, Evan Stade wrote: > lgtm Can you please commit this patch?
9 years, 2 months ago (2011-10-19 04:29:57 UTC) #3
NaveenBobbili (Motorola)
On 2011/10/19 04:29:57, NaveenBobbili (Motorola) wrote: > On 2011/10/18 20:50:48, Evan Stade wrote: > > ...
9 years, 2 months ago (2011-10-19 06:58:01 UTC) #4
Patrick Dubroy
Ni Naveen, Once you have an LGTM from a committer, you can use the commit ...
9 years, 2 months ago (2011-10-19 07:39:43 UTC) #5
NaveenBobbili (Motorola)
On 2011/10/19 07:39:43, dubroy wrote: > Ni Naveen, > > Once you have an LGTM ...
9 years, 2 months ago (2011-10-19 07:44:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8334010/9002
9 years, 2 months ago (2011-10-19 07:46:37 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-19 09:01:12 UTC) #8
Change committed as 106251

Powered by Google App Engine
This is Rietveld 408576698