Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 8333019: Make bound functions have poisoned .caller and .arguments. (Closed)

Created:
9 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 2 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Make bound functions have poisoned .caller and .arguments. Also makes func.caller return null if the caller is a bound function, matching JSC. Fix bug preventing poisoned setters from triggering. TEST=mjsunit/function-bind, mjsunit/strict-mode Committed: http://code.google.com/p/v8/source/detail?r=9681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -22 lines) Patch
M src/accessors.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/v8natives.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/function-bind.js View 1 chunk +31 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/test262/test262.status View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 2 months ago (2011-10-18 11:56:13 UTC) #1
Rico
9 years, 2 months ago (2011-10-18 12:06:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698