Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3185)

Unified Diff: chrome/common/chrome_paths.cc

Issue 8333013: Allow generator javascript test files to go anywhere in the source tree (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix escaping from windows file paths. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_paths.cc
diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc
index cfd605877752620980cf158d23f710ad72b7e572..0aabac7daa56389c2a5c1e1ee099087b187e548e 100644
--- a/chrome/common/chrome_paths.cc
+++ b/chrome/common/chrome_paths.cc
@@ -280,6 +280,13 @@ bool PathProvider(int key, FilePath* result) {
// The following are only valid in the development environment, and
// will fail if executed from an installed executable (because the
// generated path won't exist).
+ case chrome::DIR_GEN_TEST_DATA:
+ if (!PathService::Get(base::DIR_MODULE, &cur))
+ return false;
+ cur = cur.Append(FILE_PATH_LITERAL("test_data"));
+ if (!file_util::PathExists(cur)) // we don't want to create this
James Hawkins 2011/10/21 23:35:49 Capitalize sentence and add period.
Sheridan Rawlins 2011/10/22 00:09:11 Done.
+ return false;
+ break;
case chrome::DIR_TEST_DATA:
if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
return false;

Powered by Google App Engine
This is Rietveld 408576698