Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8333009: Merge 97451 - Clear WebMediaPlayerClientImpl back pointer on destruction (Closed)

Created:
9 years, 2 months ago by vrk (LEFT CHROMIUM)
Modified:
9 years, 2 months ago
Reviewers:
jschuh
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 97451 - Clear WebMediaPlayerClientImpl back pointer on destruction https://bugs.webkit.org/show_bug.cgi?id=69973 Reviewed by James Robinson. Clear the backpointer and remove the unused m_currentFrame Source/WebCore: * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::cleanupResources): (WebCore::VideoLayerChromium::updateCompositorResources): (WebCore::VideoLayerChromium::releaseProvider): * platform/graphics/chromium/VideoLayerChromium.h: Source/WebKit/chromium: * src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): (WebKit::WebMediaPlayerClientImpl::load): (WebKit::WebMediaPlayerClientImpl::getCurrentFrame): (WebKit::WebMediaPlayerClientImpl::putCurrentFrame): * src/WebMediaPlayerClientImpl.h: TBR=jschuh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -32 lines) Patch
M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h View 2 chunks +1 line, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vrk (LEFT CHROMIUM)
9 years, 2 months ago (2011-10-18 00:24:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698