Issue 8332029: Print out line number and extension name when compilation of an extension fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8332029: Print out line number and extension name when compilation of an extension fails. (Closed)

Created:
9 years, 2 months ago by Rico

Modified:
9 years, 2 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Print out line number and extension name when compilation of an extension fails. This fixes issue 305. Committed: http://code.google.com/p/v8/source/detail?r=9776

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/bootstrapper.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	src/isolate.cc	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 2 months ago (2011-10-25 13:41:00 UTC) #2

LGTM

http://codereview.chromium.org/8332029/diff/1/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/8332029/diff/1/src/isolate.cc#newcode1076
src/isolate.cc:1076: // We are bootstrapping and caught and error where the
location is set
and error -> an error

Expand Messages | Collapse Messages