Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 8332028: Remove superfluous assert. (Closed)

Created:
9 years, 2 months ago by Erik Corry
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove superfluous assert. Committed: http://code.google.com/p/v8/source/detail?r=9775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/spaces.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 2 months ago (2011-10-25 12:21:50 UTC) #1
Vyacheslav Egorov (Chromium)
this assert actually caught some bugs for me, so I don't think we should remove ...
9 years, 2 months ago (2011-10-25 12:30:04 UTC) #2
Erik Corry
There's still the almost equivalent assert at the other end of the same function. Do ...
9 years, 2 months ago (2011-10-25 13:08:39 UTC) #3
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-25 13:24:10 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698