Optionally show component extensions in options.

Optionally show component extensions in options.

Add a new switch (--show-component-extension-options) that causes
the built-in component extensions to be displayed on
chrome://settings/extensions.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106960

[Aaron Boodman, 2011-10-24 17:53:46]

lgtm, thanks!

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h...
chrome/common/chrome_switches.h:266: extern const char
kShowComponentExtensionsInOptions[];
Can you make it just --show-component-options? Slightly terser, same meaning.

[Mihai Parparita -not on Chrome, 2011-10-24 17:57:46]

Drive-by nits, feel free to ignore.

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:973: // Makes component extensions appear in
chrome://extensions/
Isn't the new canonical URL chrome://settings/extensions?

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h...
chrome/common/chrome_switches.h:266: extern const char
kShowComponentExtensionsInOptions[];
On 2011/10/24 17:53:47, Aaron Boodman wrote:
> Can you make it just --show-component-options? Slightly terser, same meaning.

FWIW "show options for components", which isn't quite the same.

[bryeung, 2011-10-24 18:06:31]

On 2011/10/24 17:57:46, Mihai Parparita wrote:
http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.cc
> File chrome/common/chrome_switches.cc (right):
> 
>
http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.c...
> chrome/common/chrome_switches.cc:973: // Makes component extensions appear in
> chrome://extensions/
> Isn't the new canonical URL chrome://settings/extensions?

That seems to be the URL I get if I browser there via the settings page, but
chrome://extensions also takes me there (and doesn't redirect).

Anyway, changed to the new chrome://settings/extensions URL.

http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h
> File chrome/common/chrome_switches.h (right):
> 
>
http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h...
> chrome/common/chrome_switches.h:266: extern const char
> kShowComponentExtensionsInOptions[];
> On 2011/10/24 17:53:47, Aaron Boodman wrote:
> > Can you make it just --show-component-options? Slightly terser, same
meaning.
> 
> FWIW "show options for components", which isn't quite the same.

I'm okay with either name (though I do have a preference for being more
verbose).  This patch has it named as Aaron requested.

[Aaron Boodman, 2011-10-24 18:19:01]

On 2011/10/24 18:06:31, bryeung wrote:
> On 2011/10/24 17:57:46, Mihai Parparita wrote:
> http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.cc
> > File chrome/common/chrome_switches.cc (right):
> > 
> >
>
http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.c...
> > chrome/common/chrome_switches.cc:973: // Makes component extensions appear
in
> > chrome://extensions/
> > Isn't the new canonical URL chrome://settings/extensions?
> 
> That seems to be the URL I get if I browser there via the settings page, but
> chrome://extensions also takes me there (and doesn't redirect).
> 
> Anyway, changed to the new chrome://settings/extensions URL.
> 
> http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h
> > File chrome/common/chrome_switches.h (right):
> > 
> >
>
http://codereview.chromium.org/8332006/diff/1/chrome/common/chrome_switches.h...
> > chrome/common/chrome_switches.h:266: extern const char
> > kShowComponentExtensionsInOptions[];
> > On 2011/10/24 17:53:47, Aaron Boodman wrote:
> > > Can you make it just --show-component-options? Slightly terser, same
> meaning.
> > 
> > FWIW "show options for components", which isn't quite the same.
> 
> I'm okay with either name (though I do have a preference for being more
> verbose).  This patch has it named as Aaron requested.

Yeah, I'm sorry. Typing/thinking too fast.

I meant: --show-component-extension-options

[bryeung, 2011-10-24 18:25:14]

Should be good now.

[Aaron Boodman, 2011-10-24 18:27:56]

lgtm w/ nit

http://codereview.chromium.org/8332006/diff/7001/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/8332006/diff/7001/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:973: // Makes component extensions appear in
chrome://settings/extensions
Nit: add a period :)

[Aaron Boodman, 2011-10-24 18:28:04]

lgtm w/ nit

[commit-bot: I haz the power, 2011-10-24 18:33:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bryeung@chromium.org/8332006/9002

[commit-bot: I haz the power, 2011-10-24 19:58:12]

Change committed as 106960