Handlify CallStubCompiler::CompileCallField.

Handlify CallStubCompiler::CompileCallField.

This function relies on a number of helpers for checking prototypes and
probing dictionaries.  It is not possible to wrap these helpers to retry
after allocation failure in a safe way---the assembler has no way to undo
what it has already assembled.

These functions have all been duplicated with handle and raw versions.  The
raw versions will eventually be removed completely.

R=ulan@chromium.org,vegorov@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9769

[Kevin Millikin (Chromium), 2011-10-24 15:55:12]

http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:6680: void
StringDictionaryLookupStub::GenerateNegativeLookup(MacroAssembler* masm,
Cannot be wrapped with retry after GC, because it assembles before trying
allocation.

http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:6744: __ CallStub(&stub);
This is the only change from the original function.

http://codereview.chromium.org/8332003/diff/2001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8332003/diff/2001/src/arm/stub-cache-arm.cc#ne...
src/arm/stub-cache-arm.cc:140:
StringDictionaryLookupStub::GenerateNegativeLookup(masm,
This is the only change from the original.

http://codereview.chromium.org/8332003/diff/2001/src/arm/stub-cache-arm.cc#ne...
src/arm/stub-cache-arm.cc:1712: Handle<Code>
CallStubCompiler::CompileCallField(Handle<JSObject> object,
This function is the only stub compiler one that was handlified.

[Vyacheslav Egorov (Chromium), 2011-10-24 16:18:31]

lgtm

http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8332003/diff/2001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:6680: void
StringDictionaryLookupStub::GenerateNegativeLookup(MacroAssembler* masm,
On 2011/10/24 15:55:12, Kevin Millikin wrote:
> Cannot be wrapped with retry after GC, because it assembles before trying
> allocation.

You can use create stub in the beginning of the function and call GetCode if you
want to ensure that it is created but no assembly is emitted.

[ulan, 2011-10-24 16:28:25]

LGTM with comments.

http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:86: Label* miss_label,
Indentation is broken.

http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:1199: if (result->IsFailure())
set_failure(Failure::cast(result));
The result can be NULL. It works but looks suspicious. :)

http://codereview.chromium.org/8332003/diff/2001/src/x64/stub-cache-x64.cc#ne...
src/x64/stub-cache-x64.cc:1604: __ bind(&miss);GenerateMissBranch();
New line between statements.