Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 8330026: CompileArrayPushCall should not use context register as a scratch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1493 matching lines...) Expand 10 before | Expand all | Expand 10 after
1504 __ bind(&attempt_to_grow_elements); 1504 __ bind(&attempt_to_grow_elements);
1505 if (!FLAG_inline_new) { 1505 if (!FLAG_inline_new) {
1506 __ jmp(&call_builtin); 1506 __ jmp(&call_builtin);
1507 } 1507 }
1508 1508
1509 __ mov(edi, Operand(esp, argc * kPointerSize)); 1509 __ mov(edi, Operand(esp, argc * kPointerSize));
1510 // Growing elements that are SMI-only requires special handling in case 1510 // Growing elements that are SMI-only requires special handling in case
1511 // the new element is non-Smi. For now, delegate to the builtin. 1511 // the new element is non-Smi. For now, delegate to the builtin.
1512 Label no_fast_elements_check; 1512 Label no_fast_elements_check;
1513 __ JumpIfSmi(edi, &no_fast_elements_check); 1513 __ JumpIfSmi(edi, &no_fast_elements_check);
1514 __ mov(esi, FieldOperand(edx, HeapObject::kMapOffset)); 1514 __ mov(ecx, FieldOperand(edx, HeapObject::kMapOffset));
1515 __ CheckFastObjectElements(esi, &call_builtin, Label::kFar); 1515 __ CheckFastObjectElements(ecx, &call_builtin, Label::kFar);
1516 __ bind(&no_fast_elements_check); 1516 __ bind(&no_fast_elements_check);
1517 1517
1518 // We could be lucky and the elements array could be at the top of 1518 // We could be lucky and the elements array could be at the top of
1519 // new-space. In this case we can just grow it in place by moving the 1519 // new-space. In this case we can just grow it in place by moving the
1520 // allocation pointer up. 1520 // allocation pointer up.
1521 1521
1522 ExternalReference new_space_allocation_top = 1522 ExternalReference new_space_allocation_top =
1523 ExternalReference::new_space_allocation_top_address(isolate()); 1523 ExternalReference::new_space_allocation_top_address(isolate());
1524 ExternalReference new_space_allocation_limit = 1524 ExternalReference new_space_allocation_limit =
1525 ExternalReference::new_space_allocation_limit_address(isolate()); 1525 ExternalReference::new_space_allocation_limit_address(isolate());
(...skipping 2490 matching lines...) Expand 10 before | Expand all | Expand 10 after
4016 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss(); 4016 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss();
4017 __ jmp(ic_miss, RelocInfo::CODE_TARGET); 4017 __ jmp(ic_miss, RelocInfo::CODE_TARGET);
4018 } 4018 }
4019 4019
4020 4020
4021 #undef __ 4021 #undef __
4022 4022
4023 } } // namespace v8::internal 4023 } } // namespace v8::internal
4024 4024
4025 #endif // V8_TARGET_ARCH_IA32 4025 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698