Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 8330021: Add write barrier helper for code patching and refactor stack check patching. (Closed)

Created:
9 years, 2 months ago by fschneider
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add write barrier helper for code patching and refactor stack check patching. The new helper avoids expensive FindCodeForInnerPointer invocation when we have the host code object available. It is used when patching stack checks. Also some comments on the ARM platform are corrected. Committed: http://code.google.com/p/v8/source/detail?r=9687

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M src/arm/deoptimizer-arm.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M src/incremental-marking.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/incremental-marking.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
Small refactoring of stack-check patching code.
9 years, 2 months ago (2011-10-18 14:59:24 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-18 15:04:12 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698