client/html/src/NodeWrappingImplementation.dart - Issue 8330003: Rename cloneNode to clone and move it into the Node interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/NodeWrappingImplementation.dart

Issue 8330003: Rename cloneNode to clone and move it into the Node interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Don't change the benchmark that uses the DOM interface. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/html/src/NodeWrappingImplementation.dart

diff --git a/client/html/src/NodeWrappingImplementation.dart b/client/html/src/NodeWrappingImplementation.dart

index 88bd8926699b3d6c5d8c4587820b762727b874fb..b07344582b13f49e153bbb70c82ed5344f0a36ac 100644

--- a/client/html/src/NodeWrappingImplementation.dart

+++ b/client/html/src/NodeWrappingImplementation.dart

@@ -211,9 +211,7 @@ class NodeWrappingImplementation extends EventTargetWrappingImplementation imple

LevelDom.unwrap(newChild), LevelDom.unwrap(refChild)));

}

- // TODO(jacobr): required for some benchmarks. Added to this class but not Node while

- // we decide what to do with it.

- Node cloneNode(bool deep) {

+ Node clone(bool deep) {

return LevelDom.wrapNode(_ptr.cloneNode(deep));

}

« no previous file with comments | « client/html/src/Node.dart ('k') | no next file » | no next file with comments »