Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: client/html/release/html.dart

Issue 8330003: Rename cloneNode to clone and move it into the Node interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't change the benchmark that uses the DOM interface. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/benchmarks/dromaeo/tests/DomModify.dart ('k') | client/html/src/Node.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/release/html.dart
diff --git a/client/html/release/html.dart b/client/html/release/html.dart
index a7f0440525937f889dc6f124c231416e268acc47..ba9d66974e788493809079bbc459fd33df64b6b2 100644
--- a/client/html/release/html.dart
+++ b/client/html/release/html.dart
@@ -20303,6 +20303,8 @@ interface Node extends EventTarget {
// insertBefore or we switch NodeList to implement LinkedList rather than
// array.
Node insertBefore(Node newChild, Node refChild);
+
+ Node clone(bool deep);
}
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -20524,9 +20526,7 @@ class NodeWrappingImplementation extends EventTargetWrappingImplementation imple
LevelDom.unwrap(newChild), LevelDom.unwrap(refChild)));
}
- // TODO(jacobr): required for some benchmarks. Added to this class but not Node while
- // we decide what to do with it.
- Node cloneNode(bool deep) {
+ Node clone(bool deep) {
return LevelDom.wrapNode(_ptr.cloneNode(deep));
}
}
« no previous file with comments | « client/html/benchmarks/dromaeo/tests/DomModify.dart ('k') | client/html/src/Node.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698