Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: net/spdy/spdy_session.cc

Issue 8330002: Changes the sending of PING to 1 secs instead (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
===================================================================
--- net/spdy/spdy_session.cc (revision 105961)
+++ net/spdy/spdy_session.cc (working copy)
@@ -237,7 +237,7 @@
int SpdySession::connection_at_risk_of_loss_ms_ = 0;
// static
-int SpdySession::trailing_ping_delay_time_ms_ = 200;
+int SpdySession::trailing_ping_delay_time_ms_ = 1000;
// static
int SpdySession::hung_interval_ms_ = 10000;
@@ -528,6 +528,11 @@
make_scoped_refptr(
new NetLogSpdySynParameter(headers, flags, stream_id, 0)));
}
+
+ // Some servers don't like too many pings, so we limit our current sending to
+ // no more than one ping for any syn sent. To do this, we avoid ever setting
+ // this to true unless we send a syn (which we have just done). This approach
+ // may change over time as servers change their responses to pings.
need_to_send_ping_ = true;
return ERR_IO_PENDING;
@@ -1542,7 +1547,8 @@
}
void SpdySession::SendPrefacePing() {
- // TODO(rtenneti): Enable sending Preface-PING after server fix.
+ // TODO(rtenneti): Send preface pings when more servers support additional
+ // pings.
// WritePingFrame(next_ping_id_);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698