Porting r9605 to arm (elements kind conversion in generated code).

test/mjsunit/elements-transition.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 33 matching lines @@
       if (i == length - 8 && test_double) {
         set(array_1, i, 0.5);
         set(array_2, i, 0.5);
         assertTrue(%HasFastDoubleElements(array_1));
         assertTrue(%HasFastDoubleElements(array_2));
       } else if (i == length - 5 && test_object) {
         set(array_1, i, 'object');
         set(array_2, i, 'object');
         assertTrue(%HasFastElements(array_1));
         assertTrue(%HasFastElements(array_2));
-      } else {
+      } else if (i != length - 3) {

[Sven Panne, 2011/10/19 06:16:11]

Some comments what each if-branch is supposed to test might be helpful.

         set(array_1, i, 2*i+1);
         set(array_2, i, 2*i+1);
       }
     }
 
     for (var i = 0; i < length; i++) {
       if (i == length - 8 && test_double) {
         assertEquals(0.5, array_1[i]);
         assertEquals(0.5, array_2[i]);
       } else if (i == length - 5 && test_object) {
         assertEquals('object', array_1[i]);
         assertEquals('object', array_2[i]);
-      } else {
+      } else if (i != length - 3) {
         assertEquals(2*i+1, array_1[i]);
         assertEquals(2*i+1, array_2[i]);
+      } else {
+        assertEquals(undefined, array_1[i]);
+        assertEquals(undefined, array_2[i]);
       }
     }
 
     assertEquals(length, array_1.length);
     assertEquals(length, array_2.length);
   }
 
-  test(false, false, function(a,i,v){ a[i] = v; }, 100);
-  test(true,  false, function(a,i,v){ a[i] = v; }, 100);
-  test(false, true,  function(a,i,v){ a[i] = v; }, 100);
-  test(true,  true,  function(a,i,v){ a[i] = v; }, 100);
+  test(false, false, function(a,i,v){ a[i] = v; }, 20);
+  test(true,  false, function(a,i,v){ a[i] = v; }, 20);
+  test(false, true,  function(a,i,v){ a[i] = v; }, 20);
+  test(true,  true,  function(a,i,v){ a[i] = v; }, 20);
 
   test(false, false, function(a,i,v){ a[i] = v; }, 10000);
   test(true,  false, function(a,i,v){ a[i] = v; }, 10000);
   test(false, true,  function(a,i,v){ a[i] = v; }, 10000);
   test(true,  true,  function(a,i,v){ a[i] = v; }, 10000);
 } else {
   print("Test skipped because smi only arrays are not supported.");
 }