Issue 8329022: Porting r9605 to arm (elements kind conversion in generated code).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8329022: Porting r9605 to arm (elements kind conversion in generated code). (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Porting r9605 to arm (elements kind conversion in generated code). Committed: http://code.google.com/p/v8/source/detail?r=9690

Patch Set 2 : Reset flag definitions to default. #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -13 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	2 chunks	+249 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	src/code-stubs.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/elements-transition.js	View	3 chunks	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Please take a look. http://codereview.chromium.org/8329022/diff/2001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/8329022/diff/2001/src/arm/stub-cache-arm.cc#newcode3303 src/arm/stub-cache-arm.cc:3303: __ mov(r3, Operand(Handle<Map>(transitioned_maps->at(i)))); Bugfix of ...

9 years, 2 months ago (2011-10-18 15:43:50 UTC) #1

Sven Panne

9 years, 2 months ago (2011-10-19 06:16:10 UTC) #2

LGTM if the unit test gets a few (short) comments

http://codereview.chromium.org/8329022/diff/2001/test/mjsunit/elements-transi...
File test/mjsunit/elements-transition.js (right):

http://codereview.chromium.org/8329022/diff/2001/test/mjsunit/elements-transi...
test/mjsunit/elements-transition.js:54: } else if (i != length - 3) {
Some comments what each if-branch is supposed to test might be helpful.

Expand Messages | Collapse Messages

Issue 8329022: Porting r9605 to arm (elements kind conversion in generated code). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Reset flag definitions to default. #

Messages