Issue 8329020: Crash fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8329020: Crash fix. (Closed)

Created:
9 years, 2 months ago by sreeram

Modified:
9 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, dharani

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Crash fix. We never reset |tab_contents_| to NULL anywhere (and indeed we can't, even in ReleasePreviewContents(), because browser.cc accesses it). We were protected from acccessing a dangling tab_contents_ before, due to the is_active() check that preceded a call to PrepareForCommit(). That was removed in http://crrev.com/105664 however; hence this fix. BUG=100521 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106075

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/browser/instant/instant_controller.cc	View		3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages