Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 8329008: Merge 102688 - Omnibox enters keyword search mode incorrectly (Closed)

Created:
9 years, 2 months ago by keishi
Modified:
9 years, 2 months ago
Reviewers:
keishi
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 102688 - Omnibox enters keyword search mode incorrectly Happens when input starts with default search engine keyword. BUG=95454 TEST=1. Set default search engine keyword to 'g'. 2. Type 'grand canyon' into omnibox. 3. Confirm that it is not in keyword search mode. Review URL: http://codereview.chromium.org/7754008 TBR=keishi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 1 chunk +6 lines, -21 lines 0 comments Download
A + chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
keishi
9 years, 2 months ago (2011-10-18 01:20:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698