Replace calls to Class::IsParameterized() by either

runtime/vm/object.h

Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h	(revision 502)
+++ runtime/vm/object.h	(working copy)
@@ -426,14 +426,6 @@
   void set_type_arguments_instance_field_offset(intptr_t value) const {
     raw_ptr()->type_arguments_instance_field_offset_ = value;
   }

[siva, 2011/10/18 05:06:19]

The old comment says IsParametrized is more efficient than calling
NumTypeArguments(), if that is valid then will we be regressing?

Also I am wondering if it would make the code more
readable if you continued to have IsParameterized and
implemented it as:
bool IsParameterized() const {
  return NumTypeArguments() > 0;
}

[regis, 2011/10/18 17:28:21]

Yes, I think I should reintroduce a helper function for efficiency and
readability. But I need to pick a better name, since this one was not clear.

-  bool IsParameterized() const {
-    if (is_finalized() || is_prefinalized()) {
-      // More efficient than calling NumTypeArguments().
-      return type_arguments_instance_field_offset() != kNoTypeArguments;
-    } else {
-      return NumTypeArguments() > 0;
-    }
-  }
 
   // The super type of this class, Object type if not explicitly specified.
   RawType* super_type() const { return raw_ptr()->super_type_; }