Issue 8328001: For no margins, or printable area margins, don't factor in the header/footer size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8328001: For no margins, or printable area margins, don't factor in the header/footer size. (Closed)

Created:
9 years, 2 months ago by vandebo (ex-Chrome)

Modified:
9 years, 2 months ago

Reviewers:
dpapad

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

For no margins, or printable area margins, don't factor in the header/footer size. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105973

Patch Set 2 : address comment #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	printing/page_setup.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/page_setup.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	printing/print_settings.cc	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dpapad

LGTM http://codereview.chromium.org/8328001/diff/1/printing/page_setup.h File printing/page_setup.h (right): http://codereview.chromium.org/8328001/diff/1/printing/page_setup.h#newcode68 printing/page_setup.h:68: // a constraint of |bounds|. Nit: Update comment.

9 years, 2 months ago (2011-10-17 23:03:03 UTC) #1

vandebo (ex-Chrome)

9 years, 2 months ago (2011-10-17 23:16:53 UTC) #2

Just waiting for try bots to go green.

http://codereview.chromium.org/8328001/diff/1/printing/page_setup.h
File printing/page_setup.h (right):

http://codereview.chromium.org/8328001/diff/1/printing/page_setup.h#newcode68
printing/page_setup.h:68: // a constraint of |bounds|.
On 2011/10/17 23:03:03, dpapad wrote:
> Nit: Update comment.

Done.

Expand Messages | Collapse Messages

Issue 8328001: For no margins, or printable area margins, don't factor in the header/footer size. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comment #

Messages