Issue 8322005: Crash fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8322005: Crash fix. (Closed)

Created:
9 years, 2 months ago by sreeram

Modified:
9 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, dharani

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Crash fix. I don't see how tab_contents_ could be NULL inside PrepareForCommit(). Even if Update() had never been called, OnAutocompleteGotFocus() should have set a valid tab_contents_. Anyway, check for it before trying to access the profile(). BUG=100521 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105858

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/instant/instant_controller.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sreeram

9 years, 2 months ago (2011-10-17 16:37:46 UTC) #3

On 2011/10/17 16:26:56, sky wrote:
> LGTM

Oh, I think I know why this crashes. If the user doesn't have a IsValidInstant()
template_url or default search engine provider, then yeah,
OnAutocompleteGotFocus() will never update |tab_contents_|. Rearranging some of
the checks in PrepareForCommit() can fix this, but I think this fix is also good
enough.

Expand Messages | Collapse Messages