compiler/lib/implementation/string_base.dart - Issue 8321024: Clean up (most) uses of Array. Still more to come in the VM corelib code base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/lib/implementation/string_base.dart

Issue 8321024: Clean up (most) uses of Array. Still more to come in the VM corelib code base. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/lib/implementation/string_base.dart

===================================================================

--- compiler/lib/implementation/string_base.dart (revision 486)

+++ compiler/lib/implementation/string_base.dart (working copy)

@@ -3,9 +3,9 @@

// BSD-style license that can be found in the LICENSE file.

class StringBase {

- static String createFromCharCodes(Array<int> charCodes) native;

+ static String createFromCharCodes(List<int> charCodes) native;

- static String join(Array<String> strings, String separator) {

+ static String join(List<String> strings, String separator) {

String s = "";

for (int i = 0; i < strings.length; i++) {

if (i > 0) {

@@ -16,7 +16,7 @@

return s;

}

- static String concatAll(Array<String> strings) {

+ static String concatAll(List<String> strings) {

return join(strings, "");

}

« no previous file with comments | « compiler/lib/implementation/string.js ('k') | compiler/lib/implementation/string_buffer.dart » ('j') | no next file with comments »