Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: compiler/lib/implementation/string.dart

Issue 8321024: Clean up (most) uses of Array. Still more to come in the VM corelib code base. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/lib/implementation/regexp.dart ('k') | compiler/lib/implementation/string.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/lib/implementation/string.dart
===================================================================
--- compiler/lib/implementation/string.dart (revision 486)
+++ compiler/lib/implementation/string.dart (working copy)
@@ -3,7 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
class StringImplementation implements String native "String" {
- factory StringImplementation.fromValues(Array<int> values) {
+ factory StringImplementation.fromValues(List<int> values) {
return _newFromValues(values);
}
@@ -128,7 +128,7 @@
}
}
- Array<String> split(Pattern pattern) {
+ List<String> split(Pattern pattern) {
if (pattern is String || pattern is JSSyntaxRegExp) {
return _split(pattern);
} else {
@@ -152,13 +152,13 @@
return result;
}
- Array<String> splitChars() {
+ List<String> splitChars() {
return _split("");
}
- Array<int> charCodes() {
+ List<int> charCodes() {
int len = length;
- Array<int> result = new Array<int>(len);
+ List<int> result = new List<int>(len);
for (int i = 0; i < len; i++) {
// It is safe to call the private function (which doesn't do
// range-checks).
@@ -178,13 +178,13 @@
int compareTo(String other) native;
- static String _newFromValues(Array<int> values) native;
+ static String _newFromValues(List<int> values) native;
String _indexOperator(int index) native;
int _charCodeAt(int index) native;
String _substringUnchecked(int startIndex, int endIndex) native;
String _replace(Pattern from, String to) native;
String _replaceAll(Pattern from, String to) native;
- Array<String> _split(Pattern pattern) native;
+ List<String> _split(Pattern pattern) native;
get dynamic() { return toString(); }
}
@@ -213,8 +213,8 @@
return pattern;
}
- Array<String> groups(Array<int> groups) {
- Array<String> result = new Array<String>();
+ List<String> groups(List<int> groups) {
+ List<String> result = new List<String>();
for (int g in groups) {
result.add(group(g));
}
« no previous file with comments | « compiler/lib/implementation/regexp.dart ('k') | compiler/lib/implementation/string.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698