Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Side by Side Diff: compiler/lib/implementation/string_base.dart

Issue 8321024: Clean up (most) uses of Array. Still more to come in the VM corelib code base. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « compiler/lib/implementation/string.js ('k') | compiler/lib/implementation/string_buffer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class StringBase { 5 class StringBase {
6 static String createFromCharCodes(Array<int> charCodes) native; 6 static String createFromCharCodes(List<int> charCodes) native;
7 7
8 static String join(Array<String> strings, String separator) { 8 static String join(List<String> strings, String separator) {
9 String s = ""; 9 String s = "";
10 for (int i = 0; i < strings.length; i++) { 10 for (int i = 0; i < strings.length; i++) {
11 if (i > 0) { 11 if (i > 0) {
12 s = s.concat(separator); 12 s = s.concat(separator);
13 } 13 }
14 s = s.concat(strings[i]); 14 s = s.concat(strings[i]);
15 } 15 }
16 return s; 16 return s;
17 } 17 }
18 18
19 static String concatAll(Array<String> strings) { 19 static String concatAll(List<String> strings) {
20 return join(strings, ""); 20 return join(strings, "");
21 } 21 }
22 22
23 } 23 }
OLDNEW
« no previous file with comments | « compiler/lib/implementation/string.js ('k') | compiler/lib/implementation/string_buffer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698