Issue 8321014: base::Bind: Convert FileUtilProxy::WriteCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8321014: base::Bind: Convert FileUtilProxy::WriteCallback. (Closed)

Created:
9 years, 2 months ago by James Hawkins

Modified:
9 years, 2 months ago

Reviewers:
csilv

CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind: Convert FileUtilProxy::WriteCallback. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105912

Patch Set 2 : Comment fixes. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -65 lines)			Patch
M	base/file_util_proxy.h	View	1	6 chunks	+9 lines, -9 lines	0 comments	Download
M	base/file_util_proxy.cc	View		4 chunks	+7 lines, -10 lines	0 comments	Download
M	content/common/net/url_fetcher.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.cc	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io.cc	View		7 chunks	+14 lines, -14 lines	0 comments	Download
M	webkit/plugins/ppapi/quota_file_io_unittest.cc	View		6 chunks	+17 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8321014/diff/1/base/file_util_proxy.h File base/file_util_proxy.h (right): http://codereview.chromium.org/8321014/diff/1/base/file_util_proxy.h#newcode174 base/file_util_proxy.h:174: // |offset + bytes_to_write| in the file. The ...

9 years, 2 months ago (2011-10-17 20:53:23 UTC) #2

James Hawkins

9 years, 2 months ago (2011-10-17 20:56:42 UTC) #3

http://codereview.chromium.org/8321014/diff/1/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8321014/diff/1/base/file_util_proxy.h#newcode174
base/file_util_proxy.h:174: // |offset + bytes_to_write| in the file. The
callback can be NULL.
On 2011/10/17 20:53:23, csilv wrote:
> "can be null"

Done.

Expand Messages | Collapse Messages

Issue 8321014: base::Bind: Convert FileUtilProxy::WriteCallback. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comment fixes. #

Messages