Issue 8321004: Show canary icon in Programs and Features (Add/Remove Programs) control panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8321004: Show canary icon in Programs and Features (Add/Remove Programs) control panel. (Closed)

Created:
9 years, 2 months ago by grt (UTC plus 2)

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Show canary icon in Programs and Features (Add/Remove Programs) control panel. BUG=100201 TEST=install canary, note that the uninstall entry has the correct icon. R=robertshield@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105825

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/installer/setup/install_worker.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/8321004/1

9 years, 2 months ago (2011-10-17 16:51:48 UTC) #3

commit-bot: I haz the power

9 years, 2 months ago (2011-10-17 16:51:49 UTC) #4

Presubmit check for 8321004-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    chrome/installer/setup/install_worker.cc:185

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages