Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: test/mjsunit/string-slices.js

Issue 8321001: Rolling back r9662. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/extensions/externalize-string-extension.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/string-slices.js
diff --git a/test/mjsunit/string-slices.js b/test/mjsunit/string-slices.js
index 2ef10c4efc08ac72134a3cd6c48f9e11f9fb0080..7c40229c75def951ac4379af31bf2754ae0bd5c3 100755
--- a/test/mjsunit/string-slices.js
+++ b/test/mjsunit/string-slices.js
@@ -190,33 +190,15 @@ assertEquals("\u03B2\u03B3\u03B4\u03B5\u03B4\u03B5\u03B6\u03B7",
utf.substring(5,1) + utf.substring(3,7));
// Externalizing strings.
-seq = "123456789qwertyuiopasdfghjklzxcvbnm";
-cons = "123456789" + "qwertyuiopasdfghjklzxcvbnm";
-check = "23456789qwertyuiopasdfghjklzxcvbn";
-
-// Externalizing a sequential string changes its encoding from ascii to
-// two-byte. The encoding of the sliced string must reflect this change too.
-slice = seq.slice(1,-1);
-assertEquals(check, slice);
-
-// Seq strings can only be externalized once across multiple stress-opt runs.
-if (isAsciiString(seq)) externalizeString(seq, true);
-assertFalse(isAsciiString(seq));
-assertFalse(isAsciiString(slice));
-
-assertEquals(check, seq.slice(1,-1));
-assertEquals(check, slice);
-assertTrue(/3456789qwe/.test(seq));
-assertEquals(5, seq.indexOf("678"));
-assertEquals("12345", seq.split("6")[0]);
-
-// Externalizing a cons string changes its encoding from ascii to two-byte,
-// but the slice depending on the cons string does not, as it still points to
-// the original cons string.
-slice = cons.slice(1,-1);
-assertEquals(check, slice);
-
-assertTrue(isAsciiString(cons));
-externalizeString(cons, true);
-assertFalse(isAsciiString(cons));
-assertTrue(isAsciiString(slice));
+var a = "123456789" + "qwertyuiopasdfghjklzxcvbnm";
+var b = "23456789qwertyuiopasdfghjklzxcvbn"
+assertEquals(a.slice(1,-1), b);
+
+assertTrue(isAsciiString(a));
+externalizeString(a, true);
+assertFalse(isAsciiString(a));
+
+assertEquals(a.slice(1,-1), b);
+assertTrue(/3456789qwe/.test(a));
+assertEquals(5, a.indexOf("678"));
+assertEquals("12345", a.split("6")[0]);
« no previous file with comments | « src/extensions/externalize-string-extension.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698