Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/extensions/externalize-string-extension.cc

Issue 8321001: Rolling back r9662. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/string-slices.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 return v8::Undefined(); 120 return v8::Undefined();
121 } 121 }
122 122
123 123
124 v8::Handle<v8::Value> ExternalizeStringExtension::IsAscii( 124 v8::Handle<v8::Value> ExternalizeStringExtension::IsAscii(
125 const v8::Arguments& args) { 125 const v8::Arguments& args) {
126 if (args.Length() != 1 || !args[0]->IsString()) { 126 if (args.Length() != 1 || !args[0]->IsString()) {
127 return v8::ThrowException(v8::String::New( 127 return v8::ThrowException(v8::String::New(
128 "isAsciiString() requires a single string argument.")); 128 "isAsciiString() requires a single string argument."));
129 } 129 }
130 Handle<String> string = Utils::OpenHandle(*args[0].As<v8::String>()); 130 return Utils::OpenHandle(*args[0].As<v8::String>())->IsAsciiRepresentation() ?
131 return string->IsAsciiRepresentationUnderneath() ? v8::True() : v8::False(); 131 v8::True() : v8::False();
132 } 132 }
133 133
134 134
135 void ExternalizeStringExtension::Register() { 135 void ExternalizeStringExtension::Register() {
136 static ExternalizeStringExtension* externalize_extension = NULL; 136 static ExternalizeStringExtension* externalize_extension = NULL;
137 if (externalize_extension == NULL) 137 if (externalize_extension == NULL)
138 externalize_extension = new ExternalizeStringExtension; 138 externalize_extension = new ExternalizeStringExtension;
139 static v8::DeclareExtension externalize_extension_declaration( 139 static v8::DeclareExtension externalize_extension_declaration(
140 externalize_extension); 140 externalize_extension);
141 } 141 }
142 142
143 } } // namespace v8::internal 143 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/string-slices.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698