Don't send preface-PING. Send trailing ping 200ms

net/spdy/spdy_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_SESSION_H_
 #define NET_SPDY_SPDY_SESSION_H_
 #pragma once
 
 #include <deque>
 #include <list>
@@ skipping 507 matching lines @@
   base::TimeTicks received_data_time_;
 
   // Indicate if we have already scheduled a delayed task to send a trailing
   // ping (and we never have more than one scheduled at a time).
   bool trailing_ping_pending_;
 
   // Indicate if we have already scheduled a delayed task to check the ping
   // status.
   bool check_ping_status_pending_;
 
-  // Indicate if the last data we sent was a ping (generally, a trailing ping).
-  // This helps us to decide if we need yet another trailing ping, or if it
-  // would be a waste of effort (and MUST not be done).
-  bool last_sent_was_ping_;
+  // Indicate if we need to send a ping (generally, a trailing ping). This helps
+  // us to decide if we need yet another trailing ping, or if it would be a
+  // waste of effort (and MUST not be done).
+  bool need_to_send_ping_;

[jar (doing other things), 2011/10/17 22:09:28]

Nice improvement on comments!

[ramant (doing other things), 2011/10/17 23:40:57]

Done.

 
   // Initial send window size for the session; can be changed by an
   // arriving SETTINGS frame; newly created streams use this value for the
   // initial send window size.
   int initial_send_window_size_;
 
   // Initial receive window size for the session; there are plans to add a
   // command line switch that would cause a SETTINGS frame with window size
   // announcement to be sent on startup; newly created streams will use
   // this value for the initial receive window size.
@@ skipping 60 matching lines @@
   const spdy::SpdyControlFlags flags_;
   const spdy::SpdyStreamId id_;
   const spdy::SpdyStreamId associated_stream_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdySynParameter);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_SESSION_H_