aura: brightness and volume bubble.

chrome/browser/chromeos/setting_level_bubble_view.cc

Index: chrome/browser/chromeos/setting_level_bubble_view.cc
diff --git a/chrome/browser/chromeos/setting_level_bubble_view.cc b/chrome/browser/chromeos/setting_level_bubble_view.cc
index 5f4ae7c825184f07cd179de8b26a8598959a04d5..5835cfb763fcc2e6f23de5d4e36e8c9060756716 100644
--- a/chrome/browser/chromeos/setting_level_bubble_view.cc
+++ b/chrome/browser/chromeos/setting_level_bubble_view.cc
@@ -30,13 +30,13 @@ namespace chromeos {
 SettingLevelBubbleView::SettingLevelBubbleView()
     : progress_bar_(NULL),
       icon_(NULL) {
+  progress_bar_ = new views::ProgressBar();
+  AddChildView(progress_bar_);

[msw, 2011/10/26 18:51:42]

Why are you moving this out of init?

[alicet1, 2011/10/27 00:34:51]

the view is created as part of bubble delegate init, but the Init() call in this
class requires args that the delegate doesn't hold, so after the bubble widget
is created, the caller (SettingLevelBubble) who does hold all the relevant bits
can initialize the view. SettingLevelBubble is one of those bubbles that need to
keep updating its views after it is created, to refresh on the setting display,
so it is holding on to the view.

[Daniel Erat, 2011/10/27 00:40:21]

Init() should still just be getting called once, right?  If so, can this be
moved back there (and maybe a DCHECK(!progress_bar_) be added at the top of
Init() to make sure that it doesn't get called more than once)?

[alicet1, 2011/10/27 15:20:06]

init is still called only once (per lifetime of the SettingLevelBubbleView),
added a dcheck on icon_, and left the progress bar creation at creation.

 }
 
 void SettingLevelBubbleView::Init(SkBitmap* icon, double level, bool enabled) {
   DCHECK(icon);
   icon_ = icon;
-  progress_bar_ = new views::ProgressBar();
-  AddChildView(progress_bar_);
   progress_bar_->SetDisplayRange(0.0, 100.0);
   progress_bar_->EnableCanvasFlippingForRTLUI(true);
   EnableCanvasFlippingForRTLUI(true);