aura: brightness and volume bubble.

chrome/browser/chromeos/setting_level_bubble_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/setting_level_bubble_view.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkBitmap.h"
@@ skipping 12 matching lines @@
 const int kProgressBarWidth = 211;
 const int kProgressBarHeight = 17;
 
 }  // namespace
 
 namespace chromeos {
 
 SettingLevelBubbleView::SettingLevelBubbleView()
     : progress_bar_(NULL),
       icon_(NULL) {
+  progress_bar_ = new views::ProgressBar();

[msw, 2011/10/27 18:30:52]

FWIW, I'm still confused by this and think it's wrong.

[alicet1, 2011/10/28 20:02:41]

updated.

+  AddChildView(progress_bar_);
 }
 
 void SettingLevelBubbleView::Init(SkBitmap* icon, double level, bool enabled) {
+  DCHECK(!icon_);
   DCHECK(icon);
   icon_ = icon;
-  progress_bar_ = new views::ProgressBar();
-  AddChildView(progress_bar_);
   progress_bar_->SetDisplayRange(0.0, 100.0);
   progress_bar_->EnableCanvasFlippingForRTLUI(true);
   EnableCanvasFlippingForRTLUI(true);
   SetLevel(level);
   SetEnabled(enabled);
 }
 
 void SettingLevelBubbleView::SetIcon(SkBitmap* icon) {
   DCHECK(icon);
   icon_ = icon;
@@ skipping 17 matching lines @@
   progress_bar_->SetBounds(width() - kPadding - kProgressBarWidth,
                            (height() - kProgressBarHeight) / 2,
                            kProgressBarWidth, kProgressBarHeight);
 }
 
 gfx::Size SettingLevelBubbleView::GetPreferredSize() {
   return gfx::Size(kWidth, kHeight);
 }
 
 }  // namespace chromeos