aura: brightness and volume bubble.

chrome/browser/chromeos/volume_bubble.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/volume_bubble.h"
 
 #include "base/memory/singleton.h"
 #include "grit/theme_resources.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "views/widget/widget.h"
 
 namespace chromeos {
 
-VolumeBubble::VolumeBubble()
-    : SettingLevelBubble(
-          ResourceBundle::GetSharedInstance().GetBitmapNamed(
-              IDR_VOLUME_BUBBLE_UP_ICON),
-          ResourceBundle::GetSharedInstance().GetBitmapNamed(
-              IDR_VOLUME_BUBBLE_DOWN_ICON),
-          ResourceBundle::GetSharedInstance().GetBitmapNamed(
-              IDR_VOLUME_BUBBLE_MUTE_ICON)) {
+VolumeBubble::VolumeBubble() : widget_(NULL) {}

[msw, 2011/10/21 02:42:06]

Move the private ctor and dtor below the public functions to match their
declaration order.

[alicet1, 2011/10/21 18:11:36]

Done.

+
+VolumeBubble::~VolumeBubble() {
+  delete widget_;
+  widget_ = NULL;
+}
+
+void VolumeBubble::ShowBubble(double percent, bool enabled) {
+  widget_= SettingLevelBubble::ShowBubble(

[Daniel Erat, 2011/10/21 00:25:21]

nit: space between 'widget_' and '='

[alicet1, 2011/10/21 18:11:36]

Done.

+      widget_,
+      ResourceBundle::GetSharedInstance().GetBitmapNamed(
+          IDR_VOLUME_BUBBLE_UP_ICON),
+      ResourceBundle::GetSharedInstance().GetBitmapNamed(
+          IDR_VOLUME_BUBBLE_DOWN_ICON),
+      ResourceBundle::GetSharedInstance().GetBitmapNamed(
+          IDR_VOLUME_BUBBLE_MUTE_ICON),
+      percent,
+      enabled);
+}
+
+void VolumeBubble::HideBubble() {
+  if (widget_)
+    widget_->Close();
 }
 
 // static
 VolumeBubble* VolumeBubble::GetInstance() {
   return Singleton<VolumeBubble>::get();
 }
 
 }  // namespace chromeos