Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: webkit/plugins/npapi/plugin_list_win.cc

Issue 8318028: Gracefully handle child process death in out-of-process plugin loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do not send the index Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_list_posix.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_list_win.cc
diff --git a/webkit/plugins/npapi/plugin_list_win.cc b/webkit/plugins/npapi/plugin_list_win.cc
index 0f832e907232993dd4eb52e42a8a67d17d18d2b1..c0b2bef38082c54f64f17dc0be92cbd515a7292f 100644
--- a/webkit/plugins/npapi/plugin_list_win.cc
+++ b/webkit/plugins/npapi/plugin_list_win.cc
@@ -267,9 +267,8 @@ void PluginList::GetPluginDirectories(std::vector<FilePath>* plugin_dirs) {
plugin_dirs->push_back(*i);
}
-void PluginList::LoadPluginsFromDir(const FilePath &path,
- ScopedVector<PluginGroup>* plugin_groups,
- std::set<FilePath>* visited_plugins) {
+void PluginList::GetPluginsInDir(
+ const FilePath& path, std::vector<FilePath>* plugins) {
WIN32_FIND_DATA find_file_data;
HANDLE find_handle;
@@ -284,8 +283,7 @@ void PluginList::LoadPluginsFromDir(const FilePath &path,
do {
if (!(find_file_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {
FilePath filename = path.Append(find_file_data.cFileName);
- LoadPlugin(filename, plugin_groups);
- visited_plugins->insert(filename);
+ plugins->push_back(filename);
}
} while (FindNextFile(find_handle, &find_file_data) != 0);
@@ -293,9 +291,7 @@ void PluginList::LoadPluginsFromDir(const FilePath &path,
FindClose(find_handle);
}
-void PluginList::LoadPluginsFromRegistry(
- ScopedVector<PluginGroup>* plugin_groups,
- std::set<FilePath>* visited_plugins) {
+void PluginList::GetPluginPathsFromRegistry(std::vector<FilePath>* plugins) {
std::set<FilePath> plugin_dirs;
GetPluginsInRegistryDirectory(
@@ -305,8 +301,7 @@ void PluginList::LoadPluginsFromRegistry(
for (std::set<FilePath>::iterator i = plugin_dirs.begin();
i != plugin_dirs.end(); ++i) {
- LoadPlugin(*i, plugin_groups);
- visited_plugins->insert(*i);
+ plugins->push_back(*i);
}
}
« no previous file with comments | « webkit/plugins/npapi/plugin_list_posix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698