Gracefully handle child process death in out-of-process plugin loading.

content/utility/utility_thread_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/utility/utility_thread_impl.h"
 
 #include <stddef.h>
 
 #include "base/file_path.h"
+#include "base/memory/scoped_vector.h"
 #include "content/common/child_process.h"
 #include "content/common/indexed_db_key.h"
 #include "content/common/utility_messages.h"
 #include "content/public/utility/content_utility_client.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBKey.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"
 #include "webkit/glue/idb_bindings.h"
 #include "webkit/glue/webkitplatformsupport_impl.h"
 #include "webkit/plugins/npapi/plugin_list.h"
@@ skipping 80 matching lines @@
 void UtilityThreadImpl::OnBatchModeStarted() {
   batch_mode_ = true;
 }
 
 void UtilityThreadImpl::OnBatchModeFinished() {
   ChildProcess::current()->ReleaseProcess();
 }
 
 #if defined(OS_POSIX)
 void UtilityThreadImpl::OnLoadPlugins(
-    const std::vector<FilePath>& extra_plugin_paths,
-    const std::vector<FilePath>& extra_plugin_dirs,
-    const std::vector<webkit::WebPluginInfo>& internal_plugins) {
+    const std::vector<FilePath>& plugin_paths) {
   webkit::npapi::PluginList* plugin_list =
       webkit::npapi::PluginList::Singleton();
 
-  // Create the PluginList and set the paths from which to load plugins. Iterate
-  // in reverse to preserve the order when pushing back.
-  std::vector<FilePath>::const_reverse_iterator it;
-  for (it = extra_plugin_paths.rbegin();
-       it != extra_plugin_paths.rend();
+  for (std::vector<FilePath>::const_iterator it = plugin_paths.begin();
+       it != plugin_paths.end();
        ++it) {
-    plugin_list->AddExtraPluginPath(*it);
-  }
-  for (it = extra_plugin_dirs.rbegin(); it != extra_plugin_dirs.rend(); ++it) {
-    plugin_list->AddExtraPluginDir(*it);
-  }
-  for (std::vector<webkit::WebPluginInfo>::const_reverse_iterator it =
-           internal_plugins.rbegin();
-       it != internal_plugins.rend();
-       ++it) {
-    plugin_list->RegisterInternalPlugin(*it);
+    ScopedVector<webkit::npapi::PluginGroup> plugin_groups;
+    plugin_list->LoadPlugin(*it, &plugin_groups);
+
+    size_t index = std::distance(plugin_paths.begin(), it);
+
+    if (!plugin_groups.size()) {

[jam, 2011/10/20 00:16:16]

nit: chrome style is if (plugin_groups.empty())

[Robert Sesek, 2011/10/20 16:00:21]

Done.

+      Send(new UtilityHostMsg_LoadPluginFailed(index, *it));
+      continue;
+    }
+
+    const webkit::npapi::PluginGroup* group = plugin_groups[0];
+    DCHECK_EQ(group->web_plugin_infos().size(), 1u);
+
+    Send(new UtilityHostMsg_LoadedPlugin(index,
+        group->web_plugin_infos().front()));
   }
 
-  std::vector<webkit::WebPluginInfo> plugins;
-  plugin_list->GetPlugins(&plugins);
-
-  Send(new UtilityHostMsg_LoadedPlugins(plugins));
   ReleaseProcessIfNeeded();
 }
 #endif