tools/perf_expectations/tests/perf_expectations_unittest.py - Issue 8318022: Wait for the make_expectations.py process to finish before checking return code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf_expectations/tests/perf_expectations_unittest.py

Issue 8318022: Wait for the make_expectations.py process to finish before checking return code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf_expectations/tests/perf_expectations_unittest.py

diff --git a/tools/perf_expectations/tests/perf_expectations_unittest.py b/tools/perf_expectations/tests/perf_expectations_unittest.py

index d2b8fc446dbafd57c0710d9fc61b4c7137a6a89a..92d4308ea794abc4f1a4625c6a5941ba46618ec6 100755

--- a/tools/perf_expectations/tests/perf_expectations_unittest.py

+++ b/tools/perf_expectations/tests/perf_expectations_unittest.py

@@ -150,6 +150,7 @@ class PerfExpectationsUnittest(unittest.TestCase):

def testNoUpdatesNeeded(self):

p = subprocess.Popen([MAKE_EXPECTATIONS, '-s'], stdout=subprocess.PIPE)

+ p.wait();

self.assertEqual(p.returncode, 0, msg='Expectations has pending updates!')

def testConfigFile(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »