Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 8318014: Make _CallFunction proxy-aware. (Closed)

Created:
9 years, 2 months ago by rossberg
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Make _CallFunction proxy-aware. Change calling convention for CallFunction stub. Some fixes regarding strict mode call traps. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9916

Patch Set 1 #

Patch Set 2 : Make it work for optimized code. #

Total comments: 2

Patch Set 3 : Addressed Kevin's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -82 lines) Patch
M src/arm/code-stubs-arm.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M src/arm/debug-arm.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 1 1 chunk +21 lines, -21 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 chunks +31 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 4 chunks +18 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M src/runtime.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download
M src/x64/debug-x64.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/proxies-function.js View 1 2 12 chunks +212 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rossberg
9 years, 2 months ago (2011-10-17 16:49:21 UTC) #1
Kevin Millikin (Chromium)
LGTM, but the macro is kind of ugly and I could live with the code ...
9 years, 2 months ago (2011-10-18 07:59:52 UTC) #2
rossberg
On 2011/10/18 07:59:52, Kevin Millikin wrote: > LGTM, but the macro is kind of ugly ...
9 years, 2 months ago (2011-10-21 13:52:25 UTC) #3
Kevin Millikin (Chromium)
I think there is an issue with deoptimization, below. http://codereview.chromium.org/8318014/diff/4001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8318014/diff/4001/src/hydrogen.cc#newcode5100 src/hydrogen.cc:5100: ...
9 years, 1 month ago (2011-11-07 14:34:50 UTC) #4
rossberg
http://codereview.chromium.org/8318014/diff/4001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/8318014/diff/4001/src/hydrogen.cc#newcode5100 src/hydrogen.cc:5100: HValue* function = Pop(); On 2011/11/07 14:34:50, Kevin Millikin ...
9 years, 1 month ago (2011-11-07 16:03:05 UTC) #5
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-08 08:27:48 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698