Issue 8318006: Resubmit 105639 - Split initial load of cookies by domains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8318006: Resubmit 105639 - Split initial load of cookies by domains (Closed)

Created:
9 years, 2 months ago by guohui

Modified:
9 years, 2 months ago

Reviewers:
erikwright (departed), commit-bot: I haz the power

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Paweł Hajdan Jr., wtc, Randy Smith (Not in Mondays), darin-cc_chromium.org, rkn

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The change list splits loading of cookies from DB by the domain key(eTLD+1). BUG=52909 TEST=NONE TBR=rdsmith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105836

Patch Set 1 : '' #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+758 lines, -145 lines)			Patch
M	chrome/browser/fast_shutdown_uitest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store.cc	View		9 chunks	+220 lines, -56 lines	0 comments	Download
A	chrome/browser/net/sqlite_persistent_cookie_store_perftest.cc	View		1 chunk	+114 lines, -0 lines	0 comments	Download
M	chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc	View	1	5 chunks	+102 lines, -12 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/cookie_monster.h	View		8 chunks	+60 lines, -11 lines	0 comments	Download
M	net/base/cookie_monster.cc	View		15 chunks	+92 lines, -24 lines	0 comments	Download
M	net/base/cookie_monster_perftest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/cookie_monster_store_test.h	View		4 chunks	+43 lines, -7 lines	0 comments	Download
M	net/base/cookie_monster_store_test.cc	View		4 chunks	+49 lines, -10 lines	0 comments	Download
M	net/base/cookie_monster_unittest.cc	View		15 chunks	+67 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

guohui

105639 was reverted due to a flaky unit test TestLoadCookiesForKey. The issue is fixed in ...

9 years, 2 months ago (2011-10-17 15:03:44 UTC) #1

commit-bot: I haz the power

9 years, 2 months ago (2011-10-17 16:20:06 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/8318006/1017

Expand Messages | Collapse Messages