Show both custom and default menu items when selection is present.

Show both custom and default menu items when selection is present.

BUG=none
TEST=none

We used to omit default context menu items if custom items are present.
Now we include both custom and default items in case there's an active selection.

We need this to be able to show custom context menu items on selection in DevTools. Here's the WebKit part of the change:

https://bugs.webkit.org/show_bug.cgi?id=69924

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106902

[caseq, 2011-10-20 14:47:40]

ping ;)

[brettw, 2011-10-20 18:27:02]

I'm having a hard time reconciling your CL description with the code. You say
"include both custom and default items in case there's an active selection" but
the code DOESN'T add developer tools items if there's an active selection.

[caseq, 2011-10-21 12:57:28]

On 2011/10/20 18:27:02, brettw wrote:
> I'm having a hard time reconciling your CL description with the code. You say
> "include both custom and default items in case there's an active selection"
but
> the code DOESN'T add developer tools items if there's an active selection.

AppendDeveloperItems() adds "Inspect Element" item on the web pages and should
not be confused with the items added by the DevTools front-end.

AppendDeveloperItems() is actually unrelated and not affected by the change (it
used to be called always, whether custom items are present or not -- another
call is at the bottom of InitMenu()).

The change affects the way we display _custom_ items, i.e. those that are added
on the WebCore side via ContextMenuProvider (which is currently solely used by
the DevTools front-end window to add items to the context menu invoked within
the DevTools). We used to skip default (i.e. those added on the browser side)
items in this case, which are actually quite useful if the context menu in
invoked on selection. Previously, DevTools avoided adding custom items when
there's a selection, so we used to display selection-specific default items, but
now we have use cases that call for both default and custom items displayed for
a selection.

[brettw, 2011-10-21 20:24:26]

lgtm

http://codereview.chromium.org/8318005/diff/1/chrome/browser/tab_contents/ren...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/8318005/diff/1/chrome/browser/tab_contents/ren...
chrome/browser/tab_contents/render_view_context_menu.cc:513:
menu_model_.AddSeparator();
I get it. Can we have a comment here like:
  // If there's a selection, don't early return when there are custom items, but
fall through to adding the normal ones after the custom ones.